Opened 10 years ago

Closed 10 years ago

#4109 closed (fixed)

[unicode][patch] Convert contrib models to use __unicode__ for representation

Reported by: Ivan Sagalaev <Maniac@…> Owned by: Jacob
Component: Uncategorized Version: other branch
Severity: Keywords: unicode
Cc: Malcolm Tredinnick, Maniac@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I think I could do the boring thing and convert whatever models are in contrib apps to use __unicode__.

Attachments (1)

4109.diff (3.5 KB) - added by Ivan Sagalaev <Maniac@…> 10 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Ivan Sagalaev <Maniac@…>

Attachment: 4109.diff added

Patch

comment:1 Changed 10 years ago by Ivan Sagalaev <Maniac@…>

Cc: Malcolm Tredinnick added
Summary: [unicode] Convert contrib models to use __unicode__ for representation[unicode][patch] Convert contrib models to use __unicode__ for representation

Added a patch. It converts strictly __str__ -> __unicode__. I didn't touch translated strings and such because we didn't come to any conclusion about them IIRC...

comment:2 Changed 10 years ago by Ivan Sagalaev <Maniac@…>

Oh.. BTW, this patch alone breaks the tests but this should be fixed by #3996

comment:3 Changed 10 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [5059]) unicode: Fixed #4109 -- Converted internal models to have a unicode method.
In most cases this is just a slight performance improvement (saves on later
conversions), in a few cases it's a good idea because things like
"username" could now be legitimately non-ASCII.

Note: See TracTickets for help on using tickets.
Back to Top