Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4107 closed (fixed)

[patch] Localization stuff

Reported by: Baptiste <baptiste.goupil@…> Owned by: hugo
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

  • Corrects an error with bin/make-messages (because of missing dictionaries) in /contrib/admindocs/views.py
  • Filter filesizeformat localizable

Attachments (2)

diff.diff (2.6 KB) - added by Baptiste <baptiste.goupil@…> 8 years ago.
patch
diff.2.diff (3.0 KB) - added by Baptiste <baptiste.goupil@…> 8 years ago.
a new string to translate in contrib/auth/models.py

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Baptiste <baptiste.goupil@…>

patch

comment:1 Changed 8 years ago by Baptiste <baptiste.goupil@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from [patch] Localization stuff + updated french po file to [patch] Localization stuff

Oops, french file will come in an other ticket.

comment:2 Changed 8 years ago by mtredinnick

  • Triage Stage changed from Unreviewed to Accepted

Are you marking the byte amount strings (e.g. "%f KB") for translation just so that the numbers are presented in the correct locale (1,234 vs. 1.234)? The strings KB, GB, etc, should not be marked for translation, since they are international abbreviations, hence it would be good to leave them out of the PO file to avoid confusion

If you could clarify what your intention is here, I'll fix it up when I commit this. No need to generate another patch.

comment:3 Changed 8 years ago by Baptiste <baptiste.goupil@…>

Actually, KB is not as international as you think : BR ?
eg., in France, a "Byte" is an "octet" (even if it is not exactly the same thing, that is the word we use). So for us, "KB" is an English notation, we write "Ko". Some people may understand, just like they would understand "yes" or "no", but this is still not French.

Changed 8 years ago by Baptiste <baptiste.goupil@…>

a new string to translate in contrib/auth/models.py

comment:4 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [5061]) Fixed #4107 -- Marked a few more strings for translation. Thanks, Baptiste.

comment:5 Changed 8 years ago by anonymous

The admindocs directory does not exist on trunk -- only on the newforms-admin branch. Please open another ticket with that change (and put [newforms-admin] at the start of the title). We don't want to mix patches for trunk and patches from branches in one ticket, because they are handled by different people.

comment:6 Changed 8 years ago by mtredinnick

Oops... last comment was by me.

comment:7 Changed 8 years ago by Baptiste <baptiste.goupil@…>

Thanks for the commit. Okay for the admindocs, sorry for the mistake, but I often forget that I am using newforms-admin ;-)

Note: See TracTickets for help on using tickets.
Back to Top