Opened 7 years ago
Closed 7 years ago
#4000 closed (fixed)
Documentation incorrectly states that filter arguments should be quoted
| Reported by: | Johan Bergström <bugs@…> | Owned by: | jacob |
|---|---|---|---|
| Component: | Documentation | Version: | master |
| Severity: | Keywords: | filter arguments quoted | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
(Found here: http://www.djangoproject.com/documentation/templates/#filters )
Documentation mentions that all arguments to filters should be quoted when it clearly isn't needed.
Regression tests for truncateword and others pass ints to filters, which made me ask people on IRC which was correct - docs or tests.
I was told that docs was incorrect and couldn't find another ticket about this - so here it is.
Attachments (1)
Change History (5)
comment:1 Changed 7 years ago by SmileyChris
- Needs documentation set
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted
comment:2 Changed 7 years ago by Johan Bergström <johan@…>
Am i missing something - isn't this only about punting that specific sentence?
Changed 7 years ago by Simon G. <dev@…>
comment:3 Changed 7 years ago by Simon G. <dev@…>
- Has patch set
- Needs documentation unset
The attached patch removes the part about quoting in the docs, and adds a test to check that filter arguments can be numeric.
comment:4 Changed 7 years ago by jacob
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Just to be clear, we're talking about passing strings to filters -- the documentation does incorrectly say "Filter arguments always are in double quotes."