Add South African / za localflavor

[Russell Cloran <russell@…>]

The attached patch adds support for South African ID numbers and postal codes.

The patch also creates django.utils.checksums (with only a luhn function for now), as ​suggested by Malcolm Tredinnick on django-developers

[Russell Cloran <russell@…>]

Patch to add za localflavor

[Russell Cloran <russell@…>]

I forgot to mention in the original submission ... the Luhn function currently returns False when it gets an input that isn't a string of digits (or an integer) -- it should perhaps raise a ValueError instead?

[Malcolm Tredinnick]

Yeah, I think the checksum function should raise an error on bad input, rather than pretending to work.

However, could you give the whole checksum function another swing? At the moment, you are converting integers to strings just so you can later convert them back to integers. How about letting integers be integers (and be careful because isintance(True, int) = True in Python, unfortunately) and converting string digits to digits. You could just do long(input_string) and anything that raises a value error is going to be wrong, for example. Check the input for leading zeros (assume leading zeros if it's too short).

I realise this sounds a bit non-specific, but I just get the feeling you're doing this in a slightly awkward fashion.

[Russell Cloran <russell@…>]

The function was initially created to accept string input -- I think this is probably the most common use case, since you're likely to store things like credit card numbers as a CharField in your database. The acceptance of integer types was tacked on, and yes, sits a bit uneasy with me too.

I'm not quite sure I get what you're saying -- should the function accept only integer input? In which case, there is going to be a long() outside the function for most use cases, and instead of a simple generator, the function needs to do %10, /10 work.

[brad@…]

Hi, this patch doesnt seem to be in the SVN tree yet, or am I missing something?

[James Bennett]

You'll want to see ​here for an explanation of what the ticket stages mean. "Accepted" does not mean "patch has been committed" -- that's what "fixed" is for.

[keegan.csmith@…]

Replying to Russell Cloran <russell@rucus.net>:

In the checksum function surely this would suffice for the check:

s = str(s)
if not s.isdigit():
    raise ValueError, "'%s' needs to be a string of digits" % s

I don't see the need to check what type s is, rather just convert it to a string. Or is this against some django conventions?

[Ben Slavin]

Removed Luhn algorithm implementation, now covered separately in #5475

[Malcolm Tredinnick]

(In [6843]) Fixed #3961 -- Added South African localflavor. Thanks, Russell Cloran.