Opened 9 years ago

Closed 7 years ago

#3940 closed (fixed)

Comma as decimal separator

Reported by: vidarl@… Owned by: Marc Garcia
Component: Internationalization Version: master
Severity: Keywords: i18n-fixed
Cc: miracle2k, alexkon@…, marcoberi@… Triage Stage: Fixed on a branch
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Support of different decimal seperators, so floats are formatted correct after use of i.e. the floatformat filter.

Change History (20)

comment:1 Changed 9 years ago by vidarl@…

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

It should also be accepted as float input in forms (and in the admin interface)

comment:2 Changed 9 years ago by Chris Beaven

Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 9 years ago by Malcolm Tredinnick

Triage Stage: Design decision neededAccepted

If the patch was aware of the currently set locale and used that to determine the separators to use, that would be reasonable. Must also work when USE_I18N=False.

comment:4 in reply to:  3 ; Changed 9 years ago by vidarl@…

Replying to mtredinnick:

If the patch was aware of the currently set locale and used that to determine the separators to use, that would be reasonable. Must also work when USE_I18N=False.

Will that work for multilingual sites?

comment:5 in reply to:  4 ; Changed 9 years ago by Malcolm Tredinnick

Replying to vidarl@epost.no:

Will that work for multilingual sites?

Could you be more specific? What problem are you worried about?

Each thread already has a concept of current locale and so do sessions, if that's what you're thinking of.

comment:6 in reply to:  5 Changed 9 years ago by vidarl@…

Replying to mtredinnick:

Replying to vidarl@epost.no:

Will that work for multilingual sites?

Could you be more specific? What problem are you worried about?

Each thread already has a concept of current locale and so do sessions, if that's what you're thinking of.

I thought of the locale module not being thread safe. But I'm not sure what else I was thinking of.

comment:7 Changed 9 years ago by Daniel Poelzleithner

Owner: changed from nobody to Daniel Poelzleithner

comment:8 Changed 9 years ago by Daniel Poelzleithner

Keywords: sprintdec01 added

comment:9 Changed 9 years ago by Daniel Poelzleithner

Keywords: sprintdec01 removed
Owner: changed from Daniel Poelzleithner to anonymous

removed project from sprintdec01 because the future of the different validators are unclear

comment:10 Changed 9 years ago by Ramiro Morales

Summary: Comma as decimal seperatorComma as decimal separator

comment:11 Changed 8 years ago by Marc Garcia

Keywords: i18n-rf added

comment:12 Changed 8 years ago by Marc Garcia

milestone: post-1.0

comment:13 Changed 8 years ago by Alexander Konovalenko

Cc: alexkon@… added

comment:14 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:15 Changed 7 years ago by Marc Garcia

Keywords: i18-fixed added; comma decimals i18n-rf removed
Owner: changed from anonymous to Marc Garcia

Fixed in branches/soc2009/i18n-improvements.

comment:16 Changed 7 years ago by Marc Garcia

Keywords: i18n-fixed added; i18-fixed removed

comment:17 Changed 7 years ago by Marc Garcia

Triage Stage: AcceptedFixed on a branch

comment:18 Changed 7 years ago by marcob

Cc: marcoberi@… added

comment:19 Changed 7 years ago by miracle2k

Cc: miracle2k added

comment:20 Changed 7 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [11964]) Fixed #7980 - Improved i18n framework to support locale aware formatting (dates and numbers) and form processing.

Thanks to Marc Garcia for working on this during his Google Summer of Code 2009!

Additionally fixes #1061, #2203, #3940, #5526, #6449, #6231, #6693, #6783, #9366 and #10891.

Note: See TracTickets for help on using tickets.
Back to Top