Opened 18 years ago

Closed 18 years ago

#3929 closed (fixed)

newforms textarea widget produces invalid HTML by default

Reported by: Luke Plant Owned by: Adrian Holovaty
Component: Forms Version: dev
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

"cols" and "rows" are required attributes for textarea, and not included in default output of the newform widget. The attached patch fixes this, with updates to tests.

(I actually have commit access, but I wanted this to go through someone else, as I've not been around for a while and I don't know much about newforms)

Attachments (1)

textarea_validity.patch​ (6.0 KB ) - added by Luke Plant 18 years ago.
Patch for textarea output and corresponding tests

Download all attachments as: .zip

Change History (3)

by Luke Plant, 18 years ago

Attachment: textarea_validity.patch​ added

Patch for textarea output and corresponding tests

comment:1 by Luke Plant, 18 years ago

By the way, I meant to mention that the default values I've chosen are the ones used by oldforms.LargeTextField

comment:2 by Adrian Holovaty, 18 years ago

Resolution: → fixed
Status: new → closed

(In [4961]) Fixed #3929 -- Newforms Textarea widget now always includes 'rows' and 'cols' attributes, even if you don't pass them in, for HTML correctness. Thanks, and welcome back, Luke Plant

Note: See TracTickets for help on using tickets.
Back to Top