Opened 10 years ago

Closed 10 years ago

#3929 closed (fixed)

newforms textarea widget produces invalid HTML by default

Reported by: Luke Plant Owned by: Adrian Holovaty
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

"cols" and "rows" are required attributes for textarea, and not included in default output of the newform widget. The attached patch fixes this, with updates to tests.

(I actually have commit access, but I wanted this to go through someone else, as I've not been around for a while and I don't know much about newforms)

Attachments (1)

textarea_validity.patch (6.0 KB) - added by Luke Plant 10 years ago.
Patch for textarea output and corresponding tests

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Luke Plant

Attachment: textarea_validity.patch added

Patch for textarea output and corresponding tests

comment:1 Changed 10 years ago by Luke Plant

By the way, I meant to mention that the default values I've chosen are the ones used by oldforms.LargeTextField

comment:2 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [4961]) Fixed #3929 -- Newforms Textarea widget now always includes 'rows' and 'cols' attributes, even if you don't pass them in, for HTML correctness. Thanks, and welcome back, Luke Plant

Note: See TracTickets for help on using tickets.
Back to Top