Code

Opened 7 years ago

Closed 7 years ago

#3876 closed (fixed)

Add Australian localflavor

Reported by: Matthew Flanagan <mattimustang@…> Owned by: adrian
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description


Attachments (2)

localflavor_au.diff (7.6 KB) - added by Matthew Flanagan <mattimustang@…> 7 years ago.
localflavor.au module
localflavor_au2.diff (6.9 KB) - added by mattimustang@… 7 years ago.
updated patch with better ValidationError message and moved tests into localflavor.py module

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Matthew Flanagan <mattimustang@…>

localflavor.au module

comment:1 Changed 7 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

The phone number validator's error message is misleading. Note that (0432) 198 765 is a valid input, but it's not 10 digits jammed together. I'm really reluctant to be too strict on phone numbers in general, since there are so many ways to enter them. This seems like a good way to go, although we should allow hyphens, too (and just strip them out).

Changed 7 years ago by mattimustang@…

updated patch with better ValidationError message and moved tests into localflavor.py module

comment:2 Changed 7 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [4955]) Fixed #3876 -- Added Australian local flavour. Thanks, Matthew Flanagan.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.