Opened 12 years ago

Closed 12 years ago

#3876 closed (fixed)

Add Australian localflavor

Reported by: Matthew Flanagan <mattimustang@…> Owned by: Adrian Holovaty
Component: Contrib apps Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description


Attachments (2)

localflavor_au.diff​ (7.6 KB) - added by Matthew Flanagan <mattimustang@…> 12 years ago.
localflavor.au module
localflavor_au2.diff​ (6.9 KB) - added by mattimustang@… 12 years ago.
updated patch with better ValidationError message and moved tests into localflavor.py module

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Matthew Flanagan <mattimustang@…>

Attachment: localflavor_au.diff​ added

localflavor.au module

comment:1 Changed 12 years ago by Malcolm Tredinnick

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

The phone number validator's error message is misleading. Note that (0432) 198 765 is a valid input, but it's not 10 digits jammed together. I'm really reluctant to be too strict on phone numbers in general, since there are so many ways to enter them. This seems like a good way to go, although we should allow hyphens, too (and just strip them out).

Changed 12 years ago by mattimustang@…

Attachment: localflavor_au2.diff​ added

updated patch with better ValidationError message and moved tests into localflavor.py module

comment:2 Changed 12 years ago by Russell Keith-Magee

Resolution: → fixed
Status: new → closed

(In [4955]) Fixed #3876 -- Added Australian local flavour. Thanks, Matthew Flanagan.

Note: See TracTickets for help on using tickets.
Back to Top