Opened 18 years ago
Closed 18 years ago
#3829 closed (fixed)
Windows setup failed
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Tools | Version: | 0.96 |
| Severity: | Keywords: | ||
| Cc: | dev@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I could be doing something daft, but I had to change the following line in setup.py:
package = dirpath[len_root_dir:].lstrip('/').replace('/', '.')
to:
package = dirpath[len_root_dir:].lstrip('
').replace('
', '.')
to make it install under Windows.
Attachments (1)
Change History (8)
comment:1 by , 18 years ago
| Cc: | added |
|---|---|
| Component: | Uncategorized → Tools |
| Owner: | changed from to |
comment:2 by , 18 years ago
If it is a problem, this would be better (assuming os.path is imported):
package = dirpath[len_root_dir:].lstrip(os.path.sep).replace(os.path.sep, '.')
comment:3 by , 18 years ago
Or better:
package = dirpath[len_root_dir:].lstrip(os.path.sep).replace(os.path.sep, os.path.curdir)
by , 18 years ago
comment:4 by , 18 years ago
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
Just noticed that this line also uses lstrip() which isn't available in Python 2.3, is it?
comment:6 by , 18 years ago
| Patch needs improvement: | unset |
|---|
Cool, I was confusing with rsplit. I don't have access to a windows machine, would someone who does like to test the patch?
comment:7 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This was fixed in a different way in [4912].
Hmm. That does look like we're assuming a *nix enviroment. Can someone else who runs windows confirm this?