Opened 18 years ago
Closed 18 years ago
#3788 closed (fixed)
[patch] newforms.fields.MultiValueField.clean should check for IndexError
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
MultiValueField.clean checks for KeyError while enumerating self.fields, while it should check for IndexError instead.
Attachments (1)
Change History (4)
by , 18 years ago
Attachment: | fields_multivaluefield.patch added |
---|
comment:1 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:2 by , 18 years ago
Resolution: | duplicate |
---|---|
Status: | closed → reopened |
Not a duplicate.
#3787 is about widgets.MultiWidget, not fields.MultiValueField
comment:3 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [5088]) Fixed #3787, #3788 -- Corrected check for IndexError on MultiValueField, and fixed the value_from_datadict method for MultiWidgets to handle Multiwidgets containing Multiwidgets. Also added a testcase walking through the use of MultiWidget/MultiValueField. Thanks to Max Derkachev for reporting these issues and providing fixes.
Marking a duplicate of #3787 since it is mentioned and included in the patch in that ticket.