Code

Opened 7 years ago

Closed 7 years ago

#3775 closed (fixed)

mysql_old backend use mysql backend

Reported by: anonymous Owned by: adrian
Component: django-admin.py inspectdb Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description


Attachments (1)

mysql_old_patch.patch (407 bytes) - added by karsu 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by karsu

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

Can you provide more info about this? why is this needed? what does it do?

comment:2 Changed 7 years ago by karsu

I underestand that mysql_old is compatible support for people who can't upgrade MySQLdb immediately. Without this patch I can't use django with mysql with older version than MySQLdb-1.2.1p2.

If I try to use mysql_old and run python manage.py syncdb it will raise ImportError "MySQLdb-1.2.1p2 or newer is required;".

Problem is mysql_old 'introspection.py' imports from django.db.backends.mysql.base import quote_name not from django.db.backends.mysql_old.base import quote_name file.

comment:3 Changed 7 years ago by Michael Radziej <mir@…>

  • Component changed from Database wrapper to django-admin.py inspectdb
  • Has patch set
  • Patch needs improvement set
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Triage Stage changed from Unreviewed to Accepted

Ah ... and the patch is for the directory django/db/backends/mysql_old! That makes sense, but it wasn't at all obvious.

Please provide a little bit more background when you write a ticket. As we don't see
what you're doing, it's sometimes hard to understand. Also, patches should contain
the full path from the django source directory, so there's no doubt about which directory
you mean.

I checked 'patch needs improvement' since the patch should really have the full path before
core developers deal with it.

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [4768]. Thanks.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.