Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#37412 closed Cleanup/optimization (fixed)

Add admin HTML breadcrumb changes to 6.1 backwards incompatible change notes

Reported by: David Owned by: Sarah Boyce
Component: contrib.admin Version: 6.1
Severity: Normal Keywords: styles
Cc: Antoliny Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

​https://github.com/django/django/pull/19492 Introduces a breaking changes in the HTML structure of the breadcrumbs which passes from a plain div to an ol with children and also relative stylesheet is no more compatible with the previous structure.

In the PR the checkbox for " I have added or updated relevant docs, including release notes if applicable." is not flagged, yet this change breaks existing template styles.

Change History (5)

comment:1 by Sarah Boyce, 3 weeks ago

Cc: Antoliny added
Owner: set to Sarah Boyce
Status: new → assigned
Summary: Breaking change in #34041 absent from release notes → Add admin HTML breadcrumb changes to 6.1 backwards incompatible change notes
Triage Stage: Unreviewed → Accepted

Hi thank you for the report
I think it is reasonable to add a note here similar to previous admin HTML changes driven by accessibility

comment:2 by Sarah Boyce, 3 weeks ago

Has patch: set

comment:3 by Jacob Walls, 3 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In 38e2188c:

Fixed #37412, Refs #34041 -- Added backwards incompatible note for admin breadcrumb changes.

comment:5 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

In 6a3b3ca:

[6.1.x] Fixed #37412, Refs #34041 -- Added backwards incompatible note for admin breadcrumb changes.

Backport of 38e2188cde2278131237fd2177b55ded3d515556 from main.

Note: See TracTickets for help on using tickets.
Back to Top