Opened 55 minutes ago

Last modified 53 minutes ago

#37387 assigned Cleanup/optimization

model_index.html table missing full width

Reported by: Jacob Walls Owned by: Django Sprints
Component: contrib.admindocs Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Noticed during an admindocs review that we're missing full width on the <table>, see screenshot (white gray background does not extend to the edge.)

Interestingly, we have the needed selector in responsive mode, so my suggestion is to just hoist the selector, something like:

  • django/contrib/admin/static/admin/css/base.css 

    diff --git a/django/contrib/admin/static/admin/css/base.css b/django/contrib/admin/static/admin/css/base.css
index 8a526f5c73..0476eb9ed6 100644
    a b a.deletelink:hover {  
    13831383.actions .button:hover {
    13841384    border-color: var(--body-quiet-color);
    13851385}
     1386
     1387/* DOCS */
     1388
     1389.module table.xfull {
     1390    width: 100%;
     1391}

  • django/contrib/admin/static/admin/css/responsive.css 

    diff --git a/django/contrib/admin/static/admin/css/responsive.css b/django/contrib/admin/static/admin/css/responsive.css
index d97601e648..b3bdf38dc5 100644
    a b button {  
    370370
    371371    /* Docs */
    372372
    373     .module table.xfull {
    374         width: 100%;
    375     }
    376 
    377373    pre.literal-block {
    378374        overflow: auto;
    379375    }

Needs verification and also maybe some thought around whether we want some screenshot test cases for contrib.admindocs?

Attachments (1)

insufficient-width.png​ (82.2 KB ) - added by Jacob Walls 55 minutes ago.

Download all attachments as: .zip

Change History (2)

by Jacob Walls, 55 minutes ago

Attachment: insufficient-width.png​ added

comment:1 by Jacob Walls, 53 minutes ago

UI/UX: set
Note: See TracTickets for help on using tickets.
Back to Top