Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#37378 closed Bug (fixed)

Extra empty breadcrumb in admindocs model_index.html

Reported by: Jacob Walls Owned by: Natalia Bidart
Component: contrib.admindocs Version: 6.1
Severity: Release blocker Keywords:
Cc: Antoliny Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Jacob Walls)

This HTML typo creates an extra <li> and very likely an extra breadcrumb. Visual regression in bc03f1064e10fa247a46d4e8a98ba9b26aa4790d.

  • django/contrib/admindocs/templates/admin_doc/model_index.html 

    diff --git a/django/contrib/admindocs/templates/admin_doc/model_index.html b/django/contrib/admindocs/templates/admin_doc/model_index.html
index 590cb34b95..82f0a9cb8a 100644
    a b  
    66{% block breadcrumbs %}
    77<ol class="breadcrumbs">
    88<li><a href="{% url 'admin:index' %}">{% translate 'Home' %}</a></li>
    9 <li><a href="{% url 'django-admindocs-docroot' %}">{% translate 'Documentation' %}</a><li>
     9<li><a href="{% url 'django-admindocs-docroot' %}">{% translate 'Documentation' %}</a></li>
    1010<li aria-current="page">{% translate 'Models' %}</li>
    1111</ol>
    1212{% endblock %}

Change History (8)

comment:1 by Jacob Walls, 3 weeks ago

Description: modified (diff)
Owner: Jacob Walls removed
Status: assigned → new

comment:2 by Jacob Walls, 3 weeks ago

Owner: set to Django Sprints
Status: new → assigned

While backportable, this isn't urgent. This could be a good ticket for a newcomer to practice writing Django tests, because I suppose we will want a regression test in TestModelIndexView.

comment:3 by Natalia Bidart, 3 weeks ago

Owner: changed from Django Sprints to Natalia Bidart

comment:4 by Natalia Bidart, 3 weeks ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

comment:5 by Natalia Bidart, 3 weeks ago

Has patch: set
Patch needs improvement: unset

comment:6 by Jacob Walls, 3 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:7 by nessita <124304+nessita@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In 479ba6d2:

Fixed #37378 -- Removed extra empty breadcrumb in admindocs model index.

Regression in bc03f1064e10fa247a46d4e8a98ba9b26aa4790d.

Thanks Jacob Walls for the report.

comment:8 by Natalia <124304+nessita@…>, 3 weeks ago

In c9f6dfb:

[6.1.x] Fixed #37378 -- Removed extra empty breadcrumb in admindocs model index.

Regression in bc03f1064e10fa247a46d4e8a98ba9b26aa4790d.

Thanks Jacob Walls for the report.

Backport of 479ba6d2812bb0613d1646d445be43f7c6ab7bc7 from main.

Note: See TracTickets for help on using tickets.
Back to Top