Admin date_hierarchy raises an unhandled exception (500) on an out-of-range year

[Philip Sørensen]

A changelist for a ModelAdmin with date_hierarchy set raises an uncaught exception (HTTP 500) when the <field>year query parameter is out of range,

instead of the intended IncorrectLookupParameters (which the changelist view turns into a harmless redirect to ?e=1).

In django/contrib/admin/views/main.py, ChangeList.get_filters() wraps only the datetime(...) construction in try/except ValueError. The to_date computation that follows is outside the try, and datetime() can raise OverflowError rather than ValueError:

• ?<datefield>year=9999 — datetime(9999, 1, 1) succeeds, then to_date = from_date.replace(year=from_date.year + 1) raises "ValueError: year 10000 is out of range" (outside the try).
• ?<datefield>year=99999999999999999999 — datetime(...) raises "OverflowError: Python int too large to convert to C long" (not caught by except ValueError).

Any authenticated staff user with view permission on such a model can trigger it, and date_hierarchy is a very common admin configuration. Django already
handles OverflowError for this same year-out-of-range int->datetime parsing pattern in views/generic/dates.py, views/static.py, template/defaultfilters.py, and contrib/auth/views.py; the admin copy is the inconsistent one.

Fix: catch (ValueError, OverflowError) and move the to_date computation inside the try. A patch with a regression test in tests/admin_changelist follows as a PR.

[Jacob Walls <jacobtylerwalls@…>]

In 935edaa9:

Fixed #37357 -- Handled out-of-range year in admin date_hierarchy.

ChangeList.get_filters() only caught ValueError around the datetime()
construction, leaving the to_date computation outside the try. An
out-of-range year query parameter (e.g. ?dateyear=9999, where
to_date's year + 1 == 10000) or a value too large for a C long
(OverflowError) escaped as an unhandled exception (HTTP 500) instead of
IncorrectLookupParameters. Catch both exceptions and compute to_date
inside the try, matching the handling already used in
views/generic/dates.py and elsewhere.