Opened 3 weeks ago

Last modified 6 hours ago

#37317 new Cleanup/optimization

Remove undocumented createcachetable <table_name…> support

Reported by: Mike Edmunds Owned by:
Component: Core (Management commands) Version: 6.1
Severity: Normal Keywords: cache
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Mike Edmunds)

The createcachetable management command used to accept one or more table_name command-line arguments. That behavior was removed from the ​documentation in 1.7 when the command was changed to iterate over all CACHES (#15888), but the ​implementation is still in place with a "Legacy behavior" comment.

Retaining the undocumented legacy behavior adds maintenance burden (e.g., in implementing features like #36830) and creates potential confusion for users who might try to run createcachetable with a CACHES alias rather than a table name.

Suggest removing support for args in createcachetable, with deprecation notices (in case there are still some scripts out there relying on the legacy behavior).

Change History (11)

comment:1 by Mike Edmunds, 3 weeks ago

Description: modified (diff)

comment:2 by Md. Saikat Islam, 3 weeks ago

I agree with removing the undocumented positional arguments from createcachetable. The legacy behavior appears to provide little value while adding maintenance and potential ambiguity with cache aliases. A deprecation path followed by removal seems reasonable.

comment:3 by Nikita Kostenko, 3 weeks ago

I'll take this if accepted - deprecation warning for the positional table-name args, then removal in the following feature release.

comment:4 by Nikita Kostenko, 3 weeks ago

Owner: set to Nikita Kostenko
Status: new → assigned

comment:5 by Nikita Kostenko, 3 weeks ago

I've implemented the deprecation locally (warning, test, 6.2 notes, deprecation timeline). I'll open a PR once this is accepted.

comment:6 by Nikita Kostenko, 2 weeks ago

Triage Stage: Unreviewed → Accepted

comment:7 by Nikita Kostenko, 2 weeks ago

Has patch: set

comment:8 by Nikita Kostenko, 2 weeks ago

Last edited 2 weeks ago by Nikita Kostenko (previous) (diff)

comment:9 by Mike Edmunds, 13 days ago

Patch needs improvement: set

comment:10 by Nikita Kostenko, 6 hours ago

Owner: Nikita Kostenko removed
Status: assigned → new

comment:11 by Nikita Kostenko, 6 hours ago

Triage Stage: Accepted → Unreviewed
Note: See TracTickets for help on using tickets.
Back to Top