Opened 17 years ago
Closed 17 years ago
#3722 closed (fixed)
[boulder-oracle] Minimum value of an Oracle PositiveIntegerField should be zero
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | other branch |
| Severity: | Keywords: | Oracle PositiveIntegerField | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In order to be consistent with PostgreSQL the PositiveIntegerField and PositiveSmallIntegerField should begin at zero instead of one.
Currently it reads (django\django\db\backends\oracle\creation.py)
'PositiveIntegerField': 'NUMBER(11) CHECK (%(column)s >= 1)', 'PositiveSmallIntegerField': 'NUMBER(11) CHECK (%(column)s >= 1)',
however I believe it should be
'PositiveIntegerField': 'NUMBER(11) CHECK (%(column)s >= 0)', 'PositiveSmallIntegerField': 'NUMBER(11) CHECK (%(column)s >= 0)',
PostgreSQL uses the following (django\django\db\backends\postgresql\creation.py)
'PositiveIntegerField': 'integer CHECK ("%(column)s" >= 0)',
'PositiveSmallIntegerField': 'smallint CHECK ("%(column)s" >= 0)',
Attachments (1)
Change History (4)
by , 17 years ago
| Attachment: | oracle_positiveinteger.patch added |
|---|
comment:1 by , 17 years ago
comment:2 by , 17 years ago
| Component: | Uncategorized → Database wrapper |
|---|---|
| Owner: | changed from to |
| Summary: | Minimum value of an Oracle PositiveIntegerField should be zero → [boulder-oracle] Minimum value of an Oracle PositiveIntegerField should be zero |
| Triage Stage: | Unreviewed → Ready for checkin |
comment:3 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
I forgot to mention that I am using the boulder-oracle-sprint branch.