Opened 3 weeks ago

Closed 3 weeks ago

#37192 closed Cleanup/optimization (wontfix)

Clarify `TaskResult.last_attempted_at`

Reported by: Johannes Maron Owned by:
Component: Tasks Version: dev
Severity: Normal Keywords:
Cc: Johannes Maron, Jake Howard Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Johannes Maron)

# Time the task was last attempted to be run.

Is the last_attempted_at starttime of the attempt or the end?

We could expand the wording, but for now updating the docstring would be sufficient.

Change History (4)

comment:1 by Johannes Maron, 3 weeks ago

Description: modified (diff)

comment:2 by Jake Howard, 3 weeks ago

Cc: Jake Howard added

It's the start of the attempt, at least as implemented.

Granted I wrote it, but to me that's clear enough to not warrant a documentation update. The "attempt" happens when the task begins executing, which is what the timestamp indicates.

comment:3 by Johannes Maron, 3 weeks ago

Thanks, I guessed that you were referring to the beginning of the attempt, but maybe one more word of docs doesn't hurt. Let's have Jacob roll the dice on this.

comment:4 by Jacob Walls, 3 weeks ago

Resolution: → wontfix
Status: new → closed 
>>> random.random()
0.356077826000224

In the docs we have "The time when the most recent Task run began execution.", so if it's a docstring-only proposal, let's avoid the churn.

Note: See TracTickets for help on using tickets.
Back to Top