Opened 3 weeks ago

Closed 2 weeks ago

#37164 closed Cleanup/optimization (fixed)

Support jsonl Deserializer subclasses' _get_lines methods

Reported by: Adam Johnson Owned by: Adam Johnson
Component: Core (Serialization) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The jsonl Deserializer class calls Deserializer._get_lines() directly, rather than via self, preventing subclasses from overriding this methods (for example, to use an alternative JSON library). This has been the case since ee5147cfd7de2add74a285537a8968ec074e70cd. Let's change it to use self.

Change History (3)

comment:1 by Adam Johnson, 3 weeks ago

Has patch: set

comment:2 by Tim Graham, 2 weeks ago

Triage Stage: Unreviewed → Ready for checkin

comment:3 by Jacob Walls <jacobtylerwalls@…>, 2 weeks ago

Resolution: → fixed
Status: assigned → closed

In 189c2d2c:

Fixed #37164 -- Supported subclasses’ _get_lines() in jsonl Deserializer.

Note: See TracTickets for help on using tickets.
Back to Top