Code

Opened 7 years ago

Closed 7 years ago

#3715 closed (fixed)

Add Japan specific Field and Widget to localflavor module.

Reported by: makoto tsuyuki <mtsuyuki@…> Owned by: adrian
Component: Contrib apps Version: master
Severity: Keywords:
Cc: mtsuyuki@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Patch to add a jp module to the django.contrib.localflavor module.

Tests are included.

Attachments (2)

jplocalflavor.diff​ (8.2 KB) - added by makoto tsuyuki <mtsuyuki@…> 7 years ago.
jplocalflavor_refine.diff​ (7.9 KB) - added by makoto tsuyuki <mtsuyuki@…> 7 years ago.
patch refined

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by makoto tsuyuki <mtsuyuki@…>

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 follow-up: Changed 7 years ago by adrian

  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

The patch includes this line, which refers to something that does exist:

from validators import jp_postal_code_re

comment:3 in reply to: ↑ 2 Changed 7 years ago by makoto tsuyuki <mtsuyuki@…>

I'm sorry about my rubbish patch.

I made my django code clean and worked again.

Changed 7 years ago by makoto tsuyuki <mtsuyuki@…>

patch refined

comment:4 Changed 7 years ago by SmileyChris

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

comment:5 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [4822]) Fixed #3715 -- Added Japanese package to django.contrib.localflavor. Thanks, Makoto Tsuyuki

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.