ModelFormSet breaks when changing prefix format

[Jort Roelofs]

I've been trying to change the way the widget prefixes are formatted to make it work nicely with some JavaScript libraries. Here I ran into the following bug.

class BookForm(forms.ModelForm):
class Meta:
...

def add_prefix(self, field_name)
# Here I use a period as separator instead of a dash.
return f"{self.prefix}.{field_name}" if self.prefix else field_name

BookFormSet = modelformset_factory(Book, form=BookForm)

So far so good, this renders the way I expect it to. However, form submission doesn't work, as the check for the primary key is hardcoded to use a dash as separator ​here. When looking for a primary key, it constructs a key with pk_key = "%s-%s" % (self.add_prefix(i), self.model._meta.pk.name), but this is inconsistent when the form itself has defined a different way to construct prefixes.

[Clifford Gama]

Thanks for the report! I verified that overriding add_prefix on FormSet works, so this bug is only scoped to ModelFormSet. (We may also need to add tests for FormSet as well.)

Would you like to prepare a patch?

[Sarah Boyce <42296566+sarahboyce@…>]

In be6a149:

Fixed #37145 -- Made ModelFormSet respect custom Form.add_prefix().