Opened 2 months ago
Last modified 2 weeks ago
#37136 assigned Cleanup/optimization
Integrate Oracle Test Pilot into CI
| Reported by: | Tim Schilling | Owned by: | Loïc LEFEVRE |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | GitHub Actions, Oracle |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
As per this forum post, there's a new tool from Oracle that's being built which is designed to help open source projects support Oracle.
The goal here is to be able to run the oracle tests with GitHub Actions using Oracle Test Pilot. Based on that, the support and reliability, we can later investigate a complete migration to the tool.
Change History (15)
follow-up: 2 comment:1 by , 2 months ago
comment:2 by , 2 months ago
| Component: | Uncategorized → Core (Other) |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
Thanks, let's evaluate this.
Replying to Loïc LEFEVRE:
Which workflow would be the best to target for Oracle Test Pilot integration?
I've tested with schedule_tests.yml by adding a new Job but please confirm.
Yep, a new job next to the postgresql job seems logical. We can always port to the PR workflow later.
comment:3 by , 2 months ago
Hi Tim,
you can find an example of a job run here: https://github.com/loiclefevre/django-otp/actions/runs/26885786028/job/79297503877
I've just commented the other jobs for the time being.
Feel free to comment.
Thanks
comment:4 by , 2 months ago
The code looks pretty manageable! https://github.com/django/django/compare/main...loiclefevre:django-otp:otp
comment:5 by , 2 months ago
Quick question: is there any possibility that Connection(s) open to the test database(s) (defaut, other) may not be closed properly while running the tests? (at the very end, in the case there are no errors)
comment:6 by , 2 months ago
Reason for asking is that I've enabled Autonomous databases 19c and 26ai and the database cleanup process fail with following errors:
- ORA-01940: cannot drop a user that is currently connected
- ORA-01940: cannot drop a user that is currently connected
see: https://github.com/loiclefevre/django-otp/actions/runs/26998861078
comment:7 by , 5 weeks ago
Some updates:
- the issues with connections still in use after tests are finished is managed at the GitHub Action level now (the setup test pilot one)
- the PR phase 1 content can be seen here: https://github.com/django/django/compare/main...loiclefevre:django-otp:otp-integration-phase-1
- remark: the commented jobs will not be commented in the final PR
- I'm awaiting some review to be done to confirm it aligns with the requirements discussed last week
- a job execution example can be seen here: https://github.com/loiclefevre/django-otp/actions/runs/28530651813/job/84578949702
comment:9 by , 4 weeks ago
| Has patch: | set |
|---|
comment:10 by , 3 weeks ago
| Patch needs improvement: | set |
|---|
follow-up: 13 comment:11 by , 3 weeks ago
Comments provided within the PR review have been implemented. Only remains the one related to Spatial tests which I believe could be done through another ticket so that we don't mix topics :)
comment:12 by , 3 weeks ago
| Patch needs improvement: | unset |
|---|
comment:13 by , 3 weeks ago
Replying to Loïc LEFEVRE:
Comments provided within the PR review have been implemented. Only remains the one related to Spatial tests which I believe could be done through another ticket so that we don't mix topics :)
Done, see #37136
comment:14 by , 3 weeks ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:15 by , 2 weeks ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Ready for checkin → Accepted |
Blocked pending a discussion with Ops Team about sandboxing.
Which workflow would be the best to target for Oracle Test Pilot integration?
I've tested with schedule_tests.yml by adding a new Job but please confirm.