Opened 18 years ago
Closed 18 years ago
#3713 closed (fixed)
use Python's make_msgid() for generating Message-ID email header
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Core (Mail) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Message-ID was asked for in #2991, commited in [4051], and had some tweaks in [4058], [4065], and [4536].
Python's email.Utils (or email.utils in python2.5) provides a function, make_msgid(), that accomplishes the same thing. Note, however that make_msgid() does not cache the hostname like our current code does.
Attachments (1)
Change History (8)
comment:1 by , 18 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
comment:2 by , 18 years ago
| Triage Stage: | Design decision needed → Accepted |
|---|
comment:5 by , 18 years ago
Not that I see - Python's email.Utils.make_msgid() calls socket.getfqdn() directly.
comment:7 by , 18 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
In [5141] I included a copy of the source from Python's stdlib and changed it to use the cached hostname, which is a real performance improvement. The stdlib version was slightly more featureful than ours, so I felt it was worth including.
Note:
See TracTickets
for help on using tickets.
If this lets us simplify our code, I'm all for it.