Opened 5 hours ago

Last modified 5 hours ago

#37049 assigned Bug

Changing a m2m through= from one custom model to another is no-op'd instead of raising an error — at Version 1

Reported by: Clifford Gama Owned by: Clifford Gama
Component: Migrations Version: dev
Severity: Normal Keywords: migrations, ManyToManyField, through
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Clifford Gama)

Bug in b25aee3b7bef07dd07bed2209efcdf1a8146112c of ticket #22476.

The check to make changes to field options like blank=True on m2m's with a custom through model no-ops is currently only checking that both through models were non-auto-created source, rather than verifying they are the same model. This means any two custom through models would satisfy the check and short-circuit.

See regression test in PR for how to reproduce.

Change History (1)

comment:1 by Clifford Gama, 5 hours ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top