Opened 4 hours ago

#37029 new Bug

change_list.html: Broken markup inside {% block pagination %}

Reported by: Oganes Gambaryan Owned by:
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

contrib/admin/templates/admin/change_list.html:

  • The layout is fine without overriding the pagination block.
  • The layout will be broken if pagination block is overridden by child templates.

The fix below:

diff --git a/django/contrib/admin/templates/admin/change_list.html b/django/contrib/admin/templates/admin/change_list.html
index 78eef88294..3b1aa04615 100644
--- a/django/contrib/admin/templates/admin/change_list.html
+++ b/django/contrib/admin/templates/admin/change_list.html
@@ -92,8 +92,8 @@
           <div class="changelist-footer">
           {% pagination cl %}
           {% if cl.formset and cl.result_count %}<input type="submit" name="_save" class="default" value="{% translate 'Save' %}">{% endif %}
-          {% endblock %}
           </div>
+          {% endblock %}
           </form>
         </div>
       </div>

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top