Opened 4 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#37020 closed Cleanup/optimization (fixed)

Adjust release instructions to stop editing *.po files fetched from Transifex

Reported by: Jacob Walls Owned by: Jacob Walls
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Jacob Walls)

Per ​forum post, the procedure for pulling & pushing files from/to Transifex has been corrupting both line numbers and plural forms, leading to, in some cases, broken *.po files that do not compile to *.mo, or *.po files that hide information (e.g. plural forms that might appear in production).

I'm working on a PR to correct the documentation. (EDIT: I think it makes more sense to wait to correct the files until our next regularly scheduled time to fetch, for the 6.1 prereleases).

Change History (7)

comment:1 by Jacob Walls, 4 weeks ago

Description: modified (diff)

comment:2 by Jacob Walls, 4 weeks ago

Has patch: set

​PR

comment:3 by Sarah Boyce, 4 weeks ago

Triage Stage: Unreviewed → Accepted

Accepting based off the forum discussion. This change sounds positive to me
I feel there is a piece of work around migrating Transifex to Weblate as a longer term plan. I tried to research current discussions on this and added a note: ​https://forum.djangoproject.com/t/improving-the-process-of-incorporating-translations-to-django/26140/17

comment:4 by Natalia Bidart, 3 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

In 4d8cc40:

Refs #37020 -- Corrected example command to update translation catalogs.

Passing the --domain flag again just overwrites the prior value.

comment:6 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In 9391bee:

Fixed #37020 -- Removed guidance to edit fetched .po files by hand.

Altering the .po files by hand was causing incorrect line numbers and
plural forms. Since our fetching procedure does not recompile any
hand-edited .po files to .mo files for production use, just accept
Transifex's plural forms as a source of truth.

​https://forum.djangoproject.com/t/discourage-releasers-from-editing-po-files-by-hand/44441

comment:7 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

In 339b72f:

[6.0.x] Fixed #37020 -- Removed guidance to edit fetched .po files by hand.

Altering the .po files by hand was causing incorrect line numbers and
plural forms. Since our fetching procedure does not recompile any
hand-edited .po files to .mo files for production use, just accept
Transifex's plural forms as a source of truth.

​https://forum.djangoproject.com/t/discourage-releasers-from-editing-po-files-by-hand/44441

Backport of 9391beeb8799a4b7deb4bb3048bd63465a0e96ef from main.

Note: See TracTickets for help on using tickets.
Back to Top