Opened 4 hours ago
Last modified 3 hours ago
#37008 new Cleanup/optimization
AutocompleteJsonView should return source_model and remote_model in process_request
| Reported by: | Mateusz Kurowski | Owned by: | |
|---|---|---|---|
| Component: | contrib.admin | Version: | 6.0 |
| Severity: | Normal | Keywords: | admin, autocomplete, AutocompleteJsonView |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Hey, I think it makes sense if you want to perform extra work in subclassed AutocompleteJsonView.
By binding these values to instance properties they are accesible in get_queryset
The lookup is already happening there's no reason to do it twice.
Change History (1)
comment:1 by , 3 hours ago
| Summary: | AutocompleteJsonView shouuld return source_model and remote_model in process_request → AutocompleteJsonView should return source_model and remote_model in process_request |
|---|
Note:
See TracTickets
for help on using tickets.