Opened 3 weeks ago

Closed 3 weeks ago

Last modified 2 weeks ago

#36944 closed Cleanup/optimization (fixed)

Truncator's docstring states that `MAX_LENGTH_HTML` is enforced but is not, also `truncatechars_html` and `truncatewords_html` docs should be corrected

Reported by: Natalia Bidart Owned by: Natalia Bidart
Component: Documentation Version: 6.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Truncator.MAX_LENGTH_HTML is set to 5,000,000 characters and this limit was used to limit the input size for processing. After ​a refactor, this limit is no longer enforced so the docs for truncatechars_html and truncatewords_html should be corrected.

Change History (8)

comment:1 by Jacob Walls, 3 weeks ago

Triage Stage: Unreviewed → Accepted

comment:2 by Natalia Bidart, 3 weeks ago

Summary: Truncator's docstring state that `MAX_LENGTH_HTML` is enforced but is not, also `truncatechars_html` and `truncatewords_html` should be corrected → Truncator's docstring state that `MAX_LENGTH_HTML` is enforced but is not, also `truncatechars_html` and `truncatewords_html` docs should be corrected

comment:3 by Natalia Bidart, 3 weeks ago

Has patch: set

comment:4 by Jacob Walls, 3 weeks ago

Summary: Truncator's docstring state that `MAX_LENGTH_HTML` is enforced but is not, also `truncatechars_html` and `truncatewords_html` docs should be corrected → Truncator's docstring states that `MAX_LENGTH_HTML` is enforced but is not, also `truncatechars_html` and `truncatewords_html` docs should be corrected
Triage Stage: Accepted → Ready for checkin

comment:5 by nessita <124304+nessita@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In bbc6818:

Fixed #36944 -- Removed MAX_LENGTH_HTML and related 5M chars limit references from HTML truncation docs.

comment:6 by Natalia <124304+nessita@…>, 3 weeks ago

In d112203:

[6.0.x] Fixed #36944 -- Removed MAX_LENGTH_HTML and related 5M chars limit references from HTML truncation docs.

Backport of bbc6818bc12f14c1764a7eb68556018195f56b59 from main.

comment:7 by Natalia <124304+nessita@…>, 3 weeks ago

In 703777cb:

[5.2.x] Fixed #36944 -- Removed MAX_LENGTH_HTML and related 5M chars limit references from HTML truncation docs.

Backport of bbc6818bc12f14c1764a7eb68556018195f56b59 from main.

comment:8 by nessita <124304+nessita@…>, 2 weeks ago

In 94e7f17e:

[5.2.x] Refs #36944 -- Added missing versionchanged annotation for MAX_LENGTH_HTML change.

Note: See TracTickets for help on using tickets.
Back to Top