Opened 7 weeks ago

Closed 3 weeks ago

#36927 closed Cleanup/optimization (fixed)

Optimize Field.deconstruct()

Reported by: Adam Johnson Owned by: Adam Johnson
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I profiled a subset of Django’s test suite (runtests.py --parallel 1 model* queries expressions*) with cProfile and found that Field.deconstruct() was the function in Django with the largest time consumed inside itself (0.123s of 7.843 total, or 1.6%).

It can be optimized by flattening its main loop for constructing keyword arguments and by performing fewer string comparisons for the path.

Change History (4)

comment:1 by Clifford Gama, 6 weeks ago

Triage Stage: Unreviewed → Accepted

Thanks for the ticket!

comment:2 by Adam Johnson, 4 weeks ago

Has patch: set

comment:3 by Clifford Gama, 4 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In e779bc7:

Fixed #36927 -- Optimized Field.deconstruct().

Note: See TracTickets for help on using tickets.
Back to Top