Opened 3 weeks ago
Last modified 5 days ago
#36925 assigned Cleanup/optimization
InlineModelAdmin docs do not mention view_on_site as a shared feature with ModelAdmin
| Reported by: | James Aylett | Owned by: | James Aylett |
|---|---|---|---|
| Component: | Documentation | Version: | 6.0 |
| Severity: | Normal | Keywords: | |
| Cc: | VIZZARD-X, Ahmed Asar | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The capability was added to resolve #8261, but while it was documented for ModelAdmin it wasn't added to the list of shared features for InlineModelAdmin.
(This should be easy enough to resolve, although I haven't checked whether there are other shared features that aren't currently listed, which would be ideal to do when resolving. I'll try to find time to check and get a PR together.)
Change History (7)
comment:2 by , 3 weeks ago
| Cc: | added |
|---|
comment:3 by , 3 weeks ago
| Cc: | added |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
comment:4 by , 3 weeks ago
Thank you for the great effort on this.
If the ticket gets accepted, I’ll start working on it right away.
comment:5 by , 9 days ago
| Owner: | changed from to |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Thanks for offering to contribute a fix, James. I think the ordering is fine as is: it seems to be in rough order of importance and clustered by similar features.
comment:6 by , 5 days ago
hello I want to help with this documentation update if it’s still open for contribution. Please let me know if you're already working on a patch, otherwise I can take a look.
comment:7 by , 5 days ago
| Has patch: | set |
|---|
Apologies for the delay, got distracted by something. Patch as https://github.com/django/django/pull/20810
There are also:
empty_value_display,autocomplete_fields,sortable_byall of which are documented in ModelAdmin (the first I've used today so it's definitely worth noting)show_full_result_countis listed in BaseModelAdmin, but I'm unconvinced it's used for inlinesget_*methods (which are also documented but effectively duplicate attributes and so are probably best left off)And the sort order for the shared features doesn't make sense; it's neither consistent with that in the ModelAdmin docs above, nor alphabetical.
I have a draft patch, but would appreciate thoughts on what the sort order for that list (around docs/contrib/admin/index.rst:2278) should be.