Opened 3 weeks ago
Closed 3 weeks ago
#36893 closed Bug (fixed)
MigrationWriter doesn't serialise elidable kwarg
| Reported by: | Leigh Greville | Owned by: | SnippyCodes |
|---|---|---|---|
| Component: | Migrations | Version: | 6.0 |
| Severity: | Normal | Keywords: | migrations runsql |
| Cc: | Jarek Glowacki | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
If a migration has elidable RunSQL operations and is serialised by MigrationWriter, they will be serialised without the elidable kwarg. This means they will now be treated as unelidable.
This issue came up for me recently when automatically generating a migration to remove stale tables/columns: the generated migration contains elidable RunSQL operations to drop the stale data, but when they are serialised they are no longer marked as elidable.
This has likely not cropped up before, as MigrationWriter is typically used by the squash command, which never needs to write the operation (cause it gets thrown away if it's elidable).
Someone from my company can pick this up if it's accepted
Change History (8)
comment:1 by , 3 weeks ago
| Cc: | added |
|---|
comment:2 by , 3 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:3 by , 3 weeks ago
| Has patch: | set |
|---|
comment:4 by , 3 weeks ago
comment:5 by , 3 weeks ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:6 by , 3 weeks ago
| Patch needs improvement: | set |
|---|
comment:7 by , 3 weeks ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
I have submitted a PR that fixes this issue by ensuring elidable=True is serialized in Run-SQL and Run -Python operations. I've also added regression tests. PR - https://github.com/django/django/pull/20614