Opened 3 weeks ago
Last modified 2 weeks ago
#36882 assigned New feature
Add debug instrumentation for callproc() in CursorDebugWrapper
| Reported by: | akshaytheflash | Owned by: | akshaytheflash |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | callproc, debug, logging |
| Cc: | akshaytheflash | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The callproc() method in CursorDebugWrapper is not currently instrumented
for debug logging, unlike execute() and executemany(). This means stored
procedure calls are not logged when DEBUG=True.
This patch adds the callproc() method to CursorDebugWrapper to log
procedure calls with timing information, consistent with how other
database operations are logged.
The fix includes:
- Implementation of callproc() in CursorDebugWrapper
- Test to verify the instrumentation works correctly
- Removal of the "XXX callproc isn't instrumented" comment
Change History (6)
comment:1 by , 3 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:2 by , 3 weeks ago
| Keywords: | stored procedures removed |
|---|---|
| Type: | Bug → New feature |
| Version: | 6.0 → dev |
comment:3 by , 3 weeks ago
| Owner: | changed from to |
|---|
comment:4 by , 3 weeks ago
follow-up: 6 comment:5 by , 2 weeks ago
| Needs documentation: | set |
|---|---|
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
Linters are failing, and needs a release note.
comment:6 by , 2 weeks ago
I’m working on fixing the linters, adding a release note, and updating the documentation.
Please let me know if there are specific improvements you’d like in the patch.
Replying to Jacob Walls:
Linters are failing, and needs a release note.
https://github.com/django/django/pull/20579