Opened 9 months ago

Last modified 11 days ago

#36882 assigned New feature

Add debug instrumentation for callproc() in CursorDebugWrapper

Reported by: akshaytheflash Owned by: akshaytheflash
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords: callproc, debug, logging
Cc: akshaytheflash, Vaibhav Pant Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The callproc() method in CursorDebugWrapper is not currently instrumented
for debug logging, unlike execute() and executemany(). This means stored
procedure calls are not logged when DEBUG=True.

This patch adds the callproc() method to CursorDebugWrapper to log
procedure calls with timing information, consistent with how other
database operations are logged.

The fix includes:

  • Implementation of callproc() in CursorDebugWrapper
  • Test to verify the instrumentation works correctly
  • Removal of the "XXX callproc isn't instrumented" comment

Change History (7)

comment:1 by Harsh007, 9 months ago

Owner: set to Harsh007
Status: new → assigned

comment:2 by Clifford Gama, 9 months ago

Keywords: stored procedures removed
Type: Bug → New feature
Version: 6.0 → dev

comment:3 by akshaytheflash, 9 months ago

Owner: changed from Harsh007 to akshaytheflash

comment:5 by Jacob Walls, 9 months ago

Needs documentation: set
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

Linters are failing, and needs a release note.

in reply to:  5 ; comment:6 by akshaytheflash, 9 months ago

I’m working on fixing the linters, adding a release note, and updating the documentation.
Please let me know if there are specific improvements you’d like in the patch.

Replying to Jacob Walls:

Linters are failing, and needs a release note.

in reply to:  6 comment:7 by Vaibhav Pant, 11 days ago

Cc: Vaibhav Pant added

Replying to akshaytheflash:

I’m working on fixing the linters, adding a release note, and updating the documentation.
Please let me know if there are specific improvements you’d like in the patch.

Replying to Jacob Walls:

Linters are failing, and needs a release note.

Hi akshaytheflash, thanks for working on this! The PR has merge conflicts now, so I wanted to check in. Are you still planning to continue? I’d be glad to help with the rebase or docs if useful, and I’d keep your commit and credit. If you’d rather keep going yourself, no worries, just let me know!

Note: See TracTickets for help on using tickets.
Back to Top