postgres.contrib.ExclusionContraint __eq__ incorrectly considers index_type case

[haki]

The equality check for ExclusionContraint in postgres.contrib.ExclusionContraint stores the index_type in the provided case, but the equality check compares the string without normalizing the case.

Unlike other props like condition where case might be important, the case of index_type (currently 'gist', 'spgist', and soon 'hash') is not significant, therefor should be ignored in equality checks.

[haki]

PR link ​https://github.com/django/django/pull/20510

[Clifford Gama]

Thanks for the report!

[Jacob Walls]

I confirmed that changing an index_type from spgist to SPGIST no longer creates a migration after this proposed change. Changes between gist and GIST were already a no-op given how deconstruct() handles the default value:

    def deconstruct(self):
...
        if self.index_type.lower() != "gist":
            kwargs["index_type"] = self.index_type

[Jacob Walls <jacobtylerwalls@…>]

In 459a3d17:

Fixed #36852 -- Ignored index_type case in ExclusionConstraint equality check.