Opened 2 months ago

Last modified 11 days ago

#36835 assigned Cleanup/optimization

Add all public API classes to django.template.__all__

Reported by: Маг Ильяс DOMA Owned by: Praful Gulani
Component: Template system Version: dev
Severity: Normal Keywords:
Cc: Маг Ильяс DOMA, jaffar Khan Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Tim Graham)

Some convenience imports in django.template aren't present in __all__. If they were added to __all__, the # NOQA annotations for unused variables could be removed.

Change History (16)

comment:1 by Jacob Walls, 2 months ago

Has patch: unset
Resolution: → invalid
Status: assigned → closed

comment:2 by Tim Graham, 2 months ago

Component: Uncategorized → Template system
Description: modified (diff)
Easy pickings: set
Keywords: easy template removed
Resolution: invalid
Status: closed → new
Summary: [template] Adding `Library` to `__all__` → Add all public API classes to django.tempate.__all__
Triage Stage: Unreviewed → Accepted
Type: Bug → Cleanup/optimization
Version: 6.0 → dev

comment:3 by SnippyCodes, 2 months ago

Owner: changed from Маг Ильяс DOMA to SnippyCodes
Status: new → assigned

comment:4 by SnippyCodes, 2 months ago

Has patch: set

Submitted a PR to address this cleanup: "​https://github.com/django/django/pull/20477"

comment:5 by Jacob Walls, 2 months ago

Summary: Add all public API classes to django.tempate.__all__ → Add all public API classes to django.template.__all__

comment:6 by Jacob Walls, 2 months ago

Has patch: unset

PR had make toast contents.

comment:7 by Jacob Walls, 2 months ago

Has patch: set
Patch needs improvement: set

comment:8 by jaffar Khan, 5 weeks ago

I created a PR on this ticket: ​https://github.com/django/django/pull/20598

comment:9 by jaffar Khan, 5 weeks ago

Cc: jaffar Khan added
Owner: changed from SnippyCodes to jaffar Khan

comment:10 by jaffar Khan, 5 weeks ago

Owner: changed from jaffar Khan to SnippyCodes

comment:11 by Praful Gulani, 2 weeks ago

Owner: changed from SnippyCodes to Praful Gulani
Patch needs improvement: unset

​PR

comment:12 by JaeHyuckSa, 13 days ago

Patch needs improvement: set

comment:13 by Priyanshu Agrawal, 12 days ago

Hi, I'd like to help improve this patch if it's available.

comment:14 by Praful Gulani, 12 days ago

Patch needs improvement: unset

in reply to:  13 ; comment:15 by Praful Gulani, 12 days ago

Replying to Priyanshu Agrawal:

Hi, I'd like to help improve this patch if it's available.

Thanks for the offer!
I've already updated the patch, it only required moving two lines down to fix a circular import, so it should be all set for review now.

in reply to:  15 comment:16 by Priyanshu Agrawal, 11 days ago

Thanks for the update! Looking forward to contributing to similar issues.

Note: See TracTickets for help on using tickets.
Back to Top