Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#36807 closed Bug (fixed)

Admin fieldset field layout issue in the Safari browser.

Reported by: Antoliny Owned by: Jacob Walls
Component: contrib.admin Version: 6.0
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Antoliny)

Currently, on Safari, fieldset fields are rendered differently from regular fields in the admin change form.


In other browsers, fieldset is rendered consistently with normal fields, and Safari should behave the same way.


This issue appears to be caused by the legend element, which seems to be unaffected by its parent flex container due to Safari specific rendering behavior.

It has been identified as a regression introduced by ​https://github.com/django/django/commit/4187da258fe212d494cb578a0bc2b52c4979ab95

Attachments (4)

fieldset_diff.png​ (114.7 KB ) - added by Antoliny 3 weeks ago.
safari_fieldset.png​ (145.0 KB ) - added by Antoliny 3 weeks ago.
change-password-chrome.png​ (113.9 KB ) - added by Jacob Walls 3 weeks ago.
change-password-safari.png​ (42.3 KB ) - added by Jacob Walls 3 weeks ago.

Download all attachments as: .zip

Change History (13)

by Antoliny, 3 weeks ago

Attachment: fieldset_diff.png​ added

by Antoliny, 3 weeks ago

Attachment: safari_fieldset.png​ added

comment:1 by Antoliny, 3 weeks ago

Description: modified (diff)

comment:2 by Pravin, 3 weeks ago

Owner: set to Pravin
Status: new → assigned

comment:3 by Pravin, 3 weeks ago

Owner: Pravin removed
Status: assigned → new

comment:4 by Jacob Walls, 3 weeks ago

Owner: set to Jacob Walls
Status: new → assigned
Triage Stage: Unreviewed → Accepted
UI/UX: set

Thanks for the triage, replicated.

by Jacob Walls, 3 weeks ago

Attachment: change-password-chrome.png​ added

by Jacob Walls, 3 weeks ago

Attachment: change-password-safari.png​ added

comment:5 by Jacob Walls, 3 weeks ago

Also affects the change password form, see uploads.

comment:6 by Jacob Walls, 3 weeks ago

Has patch: set

​PR

comment:7 by Antoliny, 3 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

Resolution: → fixed
Status: assigned → closed

In 1eac2659:

Fixed #36807 -- Fixed form field alignment under <fieldset> in the admin.

It isn't safe to set display: flex on <fieldset>, because on Safari this
interferes with display: block on child divs.

Thanks Paulo Coutinho for the report and Antoliny for the review.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

comment:9 by Jacob Walls <jacobtylerwalls@…>, 3 weeks ago

In 7b12b917:

[6.0.x] Fixed #36807 -- Fixed form field alignment under <fieldset> in the admin.

It isn't safe to set display: flex on <fieldset>, because on Safari this
interferes with display: block on child divs.

Thanks Paulo Coutinho for the report and Antoliny for the review.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

Backport of 1eac2659a102d42490f9401b08782633fa51f3e3 from main.

Note: See TracTickets for help on using tickets.
Back to Top