Opened 3 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#36783 closed Bug (fixed)

{% querystring %} loses multi-value QueryDict in 6.0

Reported by: Marc Gibbons Owned by: Marc Gibbons
Component: Template system Version: 6.0
Severity: Release blocker Keywords:
Cc: Marc Gibbons, Giannis Terzopoulos Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Given a request with query string in the path ?x=y&x=z&a=b&a=c

{% querystring %}

Expected (Django 5.2):
?x=y&x=z&a=b&a=c

Actual (Django 6.0):
?x=z&a=c

Only the last value for each key is preserved.

Change History (10)

comment:1 by Marc Gibbons, 3 weeks ago

Reproduced bug with failing test

comment:2 by Marc Gibbons, 3 weeks ago

Has patch: set
Owner: set to Marc Gibbons
Status: new → assigned

comment:3 by Jacob Walls, 3 weeks ago

Cc: Giannis Terzopoulos added
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

Thanks for the clear report and speedy fix. Regression in a39c28706aa7a8c3effd0980ae6d59ae67299d85 (#35529).

comment:4 by Jacob Walls, 3 weeks ago

Needs documentation: set

comment:5 by Jacob Walls, 3 weeks ago

Needs documentation: unset

comment:6 by Natalia Bidart, 3 weeks ago

Patch needs improvement: set

comment:7 by Jacob Walls, 3 weeks ago

Needs tests: set
Patch needs improvement: unset

comment:8 by Natalia Bidart, 2 weeks ago

Needs tests: unset
Triage Stage: Accepted → Ready for checkin

comment:9 by nessita <124304+nessita@…>, 2 weeks ago

Resolution: → fixed
Status: assigned → closed

In 922c4cf9:

Fixed #36783 -- Ensured proper handling of multi-value QueryDicts in querystring template tag.

Co-authored-by: Jacob Walls <jacobtylerwalls@…>
Co-authored-by: Natalia <124304+nessita@…>

comment:10 by Natalia <124304+nessita@…>, 2 weeks ago

In be26ac85:

[6.0.x] Fixed #36783 -- Ensured proper handling of multi-value QueryDicts in querystring template tag.

Co-authored-by: Jacob Walls <jacobtylerwalls@…>
Co-authored-by: Natalia <124304+nessita@…>

Backport of 922c4cf972e04b1ce7ecee592231106724dcfd09 from main.

Note: See TracTickets for help on using tickets.
Back to Top