BaseForm loses field sorting
|Reported by:||Chris Beaven||Owned by:||Adrian Holovaty|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Came across this in a project just now when I had overridden
BaseForm for a special form of my own. The fields were coming out in a different order from what I had specified.
The reason is that the
self.fields = self.base_fields.copy()
base_fields is a
.copy() is just the normal dict function so fields becomes a
dict class and loses field sorting.
Simple patch attached.
Change History (4)
comment:1 Changed 10 years ago by
|Patch needs improvement:||unset|
|Triage Stage:||Unreviewed → Ready for checkin|