Deprecate get_placeholder in favor of get_placeholder_sql
For consistency with other expressions that return sql and params separately (e.g. tuple[str, tuple]), we should deprecate get_placeholder for a get_placeholder_sql method that returns tuple[str, tuple] and adapt BaseSpatialField, get_geom_placeholder, and other call sites like Value.as_sql to make use of it.
Change History
(4)
| Owner: |
set to Simon Charette
|
| Status: |
new → assigned
|
| Triage Stage: |
Unreviewed → Accepted
|
| Has patch: |
set
|
| Patch needs improvement: |
set
|
| Needs documentation: |
set
|
| Needs tests: |
set
|
| Needs documentation: |
unset
|
| Needs tests: |
unset
|
| Patch needs improvement: |
unset
|
Made some progress. Once I got the full suite passing I'll add the missing tests and release note docs for the deprecation.