Opened 2 hours ago
Last modified 48 minutes ago
#36727 assigned Cleanup/optimization
Deprecate get_placeholder in favor of get_placeholder_sql
| Reported by: | Jacob Walls | Owned by: | Simon Charette |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Simon Charette | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
For consistency with other expressions that return sql and params separately (e.g. tuple[str, tuple]), we should deprecate get_placeholder for a get_placeholder_sql method that returns tuple[str, tuple] and adapt BaseSpatialField, get_geom_placeholder, and other call sites like Value.as_sql to make use of it.
Change History (1)
comment:1 by , 48 minutes ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
Note:
See TracTickets
for help on using tickets.