Opened 3 weeks ago

Last modified 12 days ago

#36727 assigned Cleanup/optimization

Deprecate get_placeholder in favor of get_placeholder_sql

Reported by: Jacob Walls Owned by: Simon Charette
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Simon Charette Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

For consistency with other expressions that ​return sql and params separately (e.g. tuple[str, tuple]), we should deprecate get_placeholder for a get_placeholder_sql method that returns tuple[str, tuple] and adapt BaseSpatialField, get_geom_placeholder, and other call sites like Value.as_sql to make use of it.

Change History (3)

comment:1 by Simon Charette, 3 weeks ago

Owner: set to Simon Charette
Status: new → assigned
Triage Stage: Unreviewed → Accepted

comment:2 by Simon Charette, 12 days ago

Has patch: set
Patch needs improvement: set

comment:3 by Simon Charette, 12 days ago

Needs documentation: set
Needs tests: set

Made some progress. Once I got the full suite passing I'll add the missing tests and release note docs for the deprecation.

Note: See TracTickets for help on using tickets.
Back to Top