Opened 13 months ago

Closed 9 days ago

#36670 closed Bug (fixed)

Admin filter_vertical widget selector chooser has incorrect background color

Reported by: Antoliny Owned by: matthewn
Component: contrib.admin Version: 5.2
Severity: Normal Keywords: filter_vertical
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Antoliny)

It seems that the background color of the selector chooser area in the current filter_vertical widget is incorrect.

While it’s not very noticeable in light mode, it becomes clearly visible in dark mode.

Light Mode


Dark Mode


Attachments (2)

light.png​ (107.4 KB ) - added by Antoliny 13 months ago.
dark.png​ (118.5 KB ) - added by Antoliny 13 months ago.

Download all attachments as: .zip

Change History (19)

by Antoliny, 13 months ago

Attachment: light.png​ added

by Antoliny, 13 months ago

Attachment: dark.png​ added

comment:1 by Antoliny, 13 months ago

Owner: set to Antoliny
Status: new → assigned

comment:2 by Antoliny, 13 months ago

Description: modified (diff)

comment:3 by Antoliny, 13 months ago

Has patch: set

comment:4 by Natalia Bidart, 13 months ago

Triage Stage: Unreviewed → Accepted

Thank you Antoliny, great catch!

comment:5 by Jacob Walls, 9 months ago

Patch needs improvement: set

comment:6 by Antoliny, 9 months ago

Patch needs improvement: unset

comment:7 by Jacob Walls, 9 months ago

Patch needs improvement: set

I don't know whether the SVG change included with the PR is necessary to solve the reported dark mode issue.

comment:8 by Antoliny, 3 months ago

Attempting to assign to Pycon Korea Sprints to make it easier to reserve tickets. Pycon Korea ends August 17, this is available for someone else to pick up on the 18th.

Last edited 3 months ago by Antoliny (previous) (diff)

comment:9 by Antoliny, 3 months ago

Owner: changed from Antoliny to Pycon Korea

comment:10 by Antoliny, 3 months ago

Owner: changed from Pycon Korea to Pycon Korea Sprints

comment:11 by Jacob Walls, 3 months ago

Owner: changed from Pycon Korea Sprints to Django Sprints

comment:12 by matthewn, 5 weeks ago

Owner: changed from Django Sprints to matthewn

Djangonaut Space Session 7 participant here. I'll take a stab at getting this one over the finish line.

comment:13 by matthewn, 3 weeks ago

Patch needs improvement: unset

comment:14 by Sarah Boyce, 2 weeks ago

Patch needs improvement: set

comment:15 by matthewn, 13 days ago

Patch needs improvement: unset

comment:16 by Sarah Boyce, 11 days ago

Triage Stage: Accepted → Ready for checkin

comment:17 by Sarah Boyce <42296566+sarahboyce@…>, 9 days ago

Resolution: → fixed
Status: assigned → closed

In 6c8143cf:

Fixed #36670 -- Improved selector colors in admin m2m filter_vertical widget.

Thanks to Antoliny for the report and earlier work on this ticket.

Note: See TracTickets for help on using tickets.
Back to Top