Opened 4 weeks ago
Last modified 12 days ago
#36667 new Cleanup/optimization
How to Request PR Reviews Without Overstepping
| Reported by: | Eddy ADEGNANDJOU | Owned by: | Eddy ADEGNANDJOU |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Eddy ADEGNANDJOU | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Co-authored by: Sarah Boyce
Contributors often express uncertainty about how to get feedback or reviews on their Django pull requests. While maintainers and fellows eventually review all submissions, the waiting period can be unclear, and contributors may hesitate to reach out for fear of being intrusive.
This ticket is inspired by a discussion between Josh Thomas and Sarah Boyce, and proposes adding a section to the Contributing to Django documentation that outlines respectful and effective ways for contributors to request reviews.
Change History (9)
comment:1 by , 4 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:2 by , 3 weeks ago
comment:3 by , 3 weeks ago
| Resolution: | → needsinfo |
|---|---|
| Status: | assigned → closed |
Thanks for the link, Mariusz. Eddy, if you have a concrete edit to suggest to that page we can take a look, but I agree we shouldn't create a new one.
comment:4 by , 3 weeks ago
Here is the discussion that suggests the ticket:
Discord: Advice on getting reviews for Django PR
The idea is to update FAQ: Contributing code area of the Django docs to include a set of guidelines mentionned in the discussion.
comment:5 by , 3 weeks ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Makes sense, we can rewrite this section to incorporate Sarah's advice.
comment:6 by , 3 weeks ago
| Resolution: | needsinfo |
|---|---|
| Status: | closed → new |
comment:7 by , 12 days ago
| Has patch: | set |
|---|
comment:9 by , 12 days ago
| Patch needs improvement: | set |
|---|
This is already covered by FAQ: Contributing code. I don't see a reason to duplicate it in another section in docs.