Opened 4 weeks ago

Last modified 12 days ago

#36667 new Cleanup/optimization

How to Request PR Reviews Without Overstepping

Reported by: Eddy ADEGNANDJOU Owned by: Eddy ADEGNANDJOU
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Eddy ADEGNANDJOU Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Co-authored by: Sarah Boyce

Contributors often express uncertainty about how to get feedback or reviews on their Django pull requests. While maintainers and fellows eventually review all submissions, the waiting period can be unclear, and contributors may hesitate to reach out for fear of being intrusive.

This ticket is inspired by a discussion between Josh Thomas and Sarah Boyce, and proposes adding a section to the Contributing to Django documentation that outlines respectful and effective ways for contributors to request reviews.

Change History (9)

comment:1 by Eddy ADEGNANDJOU, 4 weeks ago

Owner: set to Eddy ADEGNANDJOU
Status: newassigned

comment:2 by Mariusz Felisiak, 3 weeks ago

This is already covered by FAQ: Contributing code. I don't see a reason to duplicate it in another section in docs.

comment:3 by Jacob Walls, 3 weeks ago

Resolution: needsinfo
Status: assignedclosed

Thanks for the link, Mariusz. Eddy, if you have a concrete edit to suggest to that page we can take a look, but I agree we shouldn't create a new one.

comment:4 by Eddy ADEGNANDJOU, 3 weeks ago

Here is the discussion that suggests the ticket:

Discord: Advice on getting reviews for Django PR

The idea is to update FAQ: Contributing code area of the Django docs to include a set of guidelines mentionned in the discussion.

comment:5 by Jacob Walls, 3 weeks ago

Triage Stage: UnreviewedAccepted

Makes sense, we can rewrite this section to incorporate Sarah's advice.

comment:6 by Jacob Walls, 3 weeks ago

Resolution: needsinfo
Status: closednew

comment:7 by Eddy ADEGNANDJOU, 12 days ago

Has patch: set

comment:9 by Jacob Walls, 12 days ago

Patch needs improvement: set
Note: See TracTickets for help on using tickets.
Back to Top