Clarify UniqueConstraint's nulls_distinct system check warning

[Russell Owen]

I was trying to create a UniqueConstraint with nulls_distinct=False using sqlite. When I migrated my sqlite database I got this warning:

SQLite does not support unique constraints with nulls distinct.

That message implies that the value of False should work, so it is misleading.

It turns out that boolean values of nulls_distinct are only acceptable for postgresql, which I missed when I first read the docs. It would be very helpful if the warning message included the information that boolean values of nulls_distinct are not acceptable for sqlite (or whatever database is triggering the warning) so the user knows how to fix the problem.

Having the warning also include the information about the actual behavior is a nice touch, but is not the heart of the problem.

Here is the simplest model I could come up with that shows the issue:

class SimpleModel(models.Model):
    field_a = models.IntegerField(null=True)
    field_b = models.IntegerField(null=True)

    class Meta:
        constraints = [
            UniqueConstraint(
                name="simple_unique_constraint",
                fields=["field_a", "field_b"],
                nulls_distinct=False,
            ),
        ]

(The same warning is printed whether nulls_distinct is False or True, which is why it is so confusing.)

It would be also nice to emphasize the limitation of nulls_distinct in the documentation by making it warning or putting it in bold as the first line of the description of the argument.

[Tim Graham]

See #36592 for initial discussion.

[Samriddha Kumar Tripathi]

I’ve opened a pull request for this:
​https://github.com/django/django/pull/19839

[Mridul]

Hi Samriddha,
I just noticed that you submitted a PR for this ticket, which I had already assigned to myself and have been working on. In the future, please make sure to check the assignment status of tickets before starting work

Also, the PR doesn’t include the required documentation changes noted in the ticket. I request you to hold off on further work and let me finish it from here

[Mridul]

Will have a PR ready before the end of this week

[Mridul]

PR: ​https://github.com/django/django/pull/19870