Opened 3 weeks ago
Closed 3 weeks ago
#36558 closed Bug (fixed)
Unexpected updated design of the "Show all" link in the admin changelist pagination.
| Reported by: | Antoliny | Owned by: | Antoliny |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Release blocker | Keywords: | pagination |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description
Originally, the "Show all" link had the following design on hover.
It has now been changed as follows.
https://github.com/django/django/commit/3f59711581bd22ebd0f13fb040b15b69c0eee21f
This occurred during the pagination accessibility improvement work, and the design change seems to be unintended.
Attachments (4)
Change History (12)
by , 3 weeks ago
| Attachment: | changed_show_all.png added |
|---|
by , 3 weeks ago
| Attachment: | original_show_all.png added |
|---|
comment:1 by , 3 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
follow-up: 3 comment:2 by , 3 weeks ago
| Severity: | Normal → Release blocker |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
by , 3 weeks ago
| Attachment: | image-20250818-094905.png added |
|---|
by , 3 weeks ago
| Attachment: | image-20250818-094929.png added |
|---|
comment:3 by , 3 weeks ago
Replying to Natalia Bidart:
Thank you Antoliny for this report. I can confirm that I see the same thing, though I also see the "Show all" (and all entry/rows) with an underline. Personally, the underline bothers me, but is this was already discussed with the accessibility team, I won't get into that at all.
I can reproduce the "blue hover" for "show all", I don't think it's terrible but I agree we should ensure it looks like the existing links where the hover is a darker tone of the text color. I'll attach some screenshots.
Thanks for adding the screenshots.
I think in my example the branch wasn’t up to date, which is why the underline didn’t appear.
The underline was added in this ticket and was intentionally included for accessibility reasons.
I also agree that it would be better if the hover state matched the existing links by showing a darker tone of the text color.
Currently, the pagination button design is being applied to "show all."
comment:5 by , 3 weeks ago
| Needs tests: | set |
|---|
comment:6 by , 3 weeks ago
| Needs tests: | unset |
|---|
comment:7 by , 3 weeks ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Thank you Antoliny for this report. I can confirm that I see the same thing, though I also see the "Show all" (and all entry/rows) with an underline. Personally, the underline bothers me, but is this was already discussed with the accessibility team, I won't get into that at all.
I can reproduce the "blue hover" for "show all", I don't think it's terrible but I agree we should ensure it looks like the existing links where the hover is a darker tone of the text color. I'll attach some screenshots.