Opened 4 weeks ago

Last modified 12 days ago

#36553 assigned Cleanup/optimization

Improve the semantic structure of admin widgets.

Reported by: Antoliny Owned by: Antoliny
Component: contrib.admin Version: 5.2
Severity: Normal Keywords: accessibility
Cc: Antoliny Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Some of the widgets currently in the admin use <p> tags as their wrapper elements.

The current structure uses <p> tags, and for fields that can span multiple lines, such as DateTime and URL fields, <br> tags are used to provide visual line breaks.
Since <p> tags represent paragraphs, they are not suitable as wrappers for elements containing inputs, as is the case here. I believe this tag should be changed to a <div>.
Additionally, <br> tags are used for visual line breaks, but it would be more appropriate to remove them and implement the spacing using CSS.

Change History (7)

comment:1 by Sarah Boyce, 4 weeks ago

Triage Stage: UnreviewedAccepted

comment:2 by Antoliny, 4 weeks ago

Owner: set to Antoliny
Status: newassigned

comment:3 by Antoliny, 4 weeks ago

Has patch: set

comment:4 by Antoliny, 3 weeks ago

Needs tests: set
Patch needs improvement: set

comment:5 by Antoliny, 3 weeks ago

Needs tests: unset
Patch needs improvement: unset

comment:6 by Sarah Boyce, 2 weeks ago

Patch needs improvement: set

comment:7 by Antoliny, 12 days ago

Patch needs improvement: unset
Note: See TracTickets for help on using tickets.
Back to Top