Opened 17 years ago

Closed 17 years ago

#3652 closed (worksforme)

ChoiceField formfield for IntegerField and CharField

Reported by: Øyvind Saltvik <oyvind.saltvik@…> Owned by: Craig Ogg
Component: Forms Version: dev
Severity: Keywords: newforms choicefield integerfield charfield
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Patch for choicefields for model fields with choices.

Attachments (2)

4664-choicefield.patch (3.7 KB ) - added by Øyvind Saltvik <oyvind.saltvik@…> 17 years ago.
ChoiceField patch
6213-choicefield-test-only.patch (1.4 KB ) - added by Craig Ogg 17 years ago.
Only the unit test portion of patch against current version of trunk

Download all attachments as: .zip

Change History (6)

by Øyvind Saltvik <oyvind.saltvik@…>, 17 years ago

Attachment: 4664-choicefield.patch added

ChoiceField patch

comment:1 by Chris Beaven, 17 years ago

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

I'm not keen on how this changes ChoiceField, but I like the overall idea...

comment:2 by Craig Ogg, 17 years ago

Owner: changed from nobody to Craig Ogg

by Craig Ogg, 17 years ago

Only the unit test portion of patch against current version of trunk

comment:3 by Craig Ogg, 17 years ago

I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.

in reply to:  3 comment:4 by James Bennett, 17 years ago

Resolution: worksforme
Status: newclosed

Replying to cogg:

I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.

Agreed; this seems to cover something that already works. If anyone can explain why this isn't so, please re-open with a more specific explanation.

Note: See TracTickets for help on using tickets.
Back to Top