Opened 10 years ago

Closed 9 years ago

#3652 closed (worksforme)

ChoiceField formfield for IntegerField and CharField

Reported by: Øyvind Saltvik <oyvind.saltvik@…> Owned by: Craig Ogg
Component: Forms Version: master
Severity: Keywords: newforms choicefield integerfield charfield
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Patch for choicefields for model fields with choices.

Attachments (2)

4664-choicefield.patch (3.7 KB) - added by Øyvind Saltvik <oyvind.saltvik@…> 10 years ago.
ChoiceField patch
6213-choicefield-test-only.patch (1.4 KB) - added by Craig Ogg 9 years ago.
Only the unit test portion of patch against current version of trunk

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Øyvind Saltvik <oyvind.saltvik@…>

Attachment: 4664-choicefield.patch added

ChoiceField patch

comment:1 Changed 9 years ago by Chris Beaven

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

I'm not keen on how this changes ChoiceField, but I like the overall idea...

comment:2 Changed 9 years ago by Craig Ogg

Owner: changed from nobody to Craig Ogg

Changed 9 years ago by Craig Ogg

Only the unit test portion of patch against current version of trunk

comment:3 Changed 9 years ago by Craig Ogg

I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.

comment:4 in reply to:  3 Changed 9 years ago by James Bennett

Resolution: worksforme
Status: newclosed

Replying to cogg:

I am not sure what was intended here, but it appears the requested functionality is already present because running the supplied test against the current trunk succeeds. I think this ticket should be closed as fixed or more explanation should be provided.

Agreed; this seems to cover something that already works. If anyone can explain why this isn't so, please re-open with a more specific explanation.

Note: See TracTickets for help on using tickets.
Back to Top