The range of the pagination block on the admin ChangeList page is incorrect.

[Antoliny]

Recently, accessibility improvements were made to the ChangeList pagination on the admin page.​PR
As part of that process, the save button that was previously within the pagination block was separated.
However, the current pagination block still includes the save button within its range.

        {% block pagination %}
        <div class="changelist-footer">
        {% pagination cl %}
        {% if cl.formset and cl.result_count %}<input type="submit" name="_save" class="default" value="{% translate 'Save' %}">{% endif %}
        {% endblock %}
        </div>

As a result, when overriding the template and customizing the contents of the pagination block, the save button may be unintentionally removed.
The range of the pagination block should be adjusted to include only the pagination template tags.

[Antoliny]

​PR

[Sarah Boyce]

Previously the save button was included in django/contrib/admin/templates/admin/pagination.html which was rendered via the pagination_tag inside the pagination template block
Since the recent accessibility changes, the save button is no longer in django/contrib/admin/templates/admin/pagination.html but is still in the pagination template block

Given that when folks were overriding the pagination block before they would have had to have handled the save button, I think what we have currently is the most backwards compatible

[Antoliny]

Replying to Sarah Boyce:

Previously the save button was included in django/contrib/admin/templates/admin/pagination.html which was rendered via the pagination_tag inside the pagination template block
Since the recent accessibility changes, the save button is no longer in django/contrib/admin/templates/admin/pagination.html but is still in the pagination template block

Given that when folks were overriding the pagination block before they would have had to have handled the save button, I think what we have currently is the most backwards compatible

Ah, I hadn’t considered that.
Now that I think about it, to maintain backwards compatibility, it does make sense to keep the current structure since the input button was previously included within the pagination block.