Opened 3 months ago
Closed 3 months ago
#36457 closed Cleanup/optimization (wontfix)
Convert methods .send_mail(), .get_users() from PasswordResetForm and .get_user() from PasswordResetConfirmView into functions.
| Reported by: | keter2002 | Owned by: | |
|---|---|---|---|
| Component: | contrib.auth | Version: | dev |
| Severity: | Normal | Keywords: | users, email, PasswordResetForm, PasswordResetConfirmView, auth, method, id |
| Cc: | keter2002 | Triage Stage: | Unreviewed |
| Has patch: | no | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The methods .send_mail(), .get_users() from PasswordResetForm and .get_user() from PasswordResetConfirmView could be reused in other views and forms to list all active users with a given e-mail, send a formatted e-mail, or get a user by their base64 id.
Change History (2)
comment:1 by , 3 months ago
| Needs documentation: | set |
|---|
comment:2 by , 3 months ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
As each can be called already doing
PasswordResetForm().send_mail(), I personally don't see much reason to refactor hereAs this is suggesting a change to the API, you should propose and discuss this with the community. To do that, please raise this on the new feature tracker.
I'll close the ticket for now, but if the community agrees with the proposal, please return to this ticket and reference the discussion so we can re-open it. For more information, please refer to the documented guidelines for requesting features.