#36357 closed Bug (fixed)
inspectdb creates a redundant unique_together for composite primary keys
| Reported by: | Baptiste Mispelon | Owned by: | Baptiste Mispelon |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 5.2 |
| Severity: | Release blocker | Keywords: | CompositePrimaryKey |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
With the following table:
CREATE TABLE example ( a integer, b integer, c integer, PRIMARY KEY (a, c) );
Running inspectdb produces the following model definition:
class Example(models.Model): pk = models.CompositePrimaryKey('a', 'c') a = models.IntegerField() b = models.IntegerField(blank=True, null=True) c = models.IntegerField() class Meta: managed = False db_table = 'example' unique_together = (('a', 'c'),)
I'm pretty sure the last unique_together = (('a', 'c'),) is redundant since the pk = models.CompositePrimaryKey('a', 'c') already implies uniqueness, no?
Change History (6)
comment:1 by , 7 months ago
| Has patch: | set |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
comment:2 by , 7 months ago
| Severity: | Normal → Release blocker |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Cleanup/optimization → Bug |
Thanks for the report Baptiste.
Marked as a bug in a newly released feature.
comment:3 by , 7 months ago
| Needs documentation: | set |
|---|
comment:4 by , 7 months ago
| Needs documentation: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Here's a draft PR with a test and a fix: https://github.com/django/django/pull/19430
I'll add release notes if the ticket is accepted.