BaseGeometryWidget unncessarily writes an error log when deserializing malformed geometry

[David Buhler]

The following bit of error logging happens during deserialization of malformed geometry:

​https://github.com/django/django/blob/stable/4.2.x/django/contrib/gis/forms/widgets.py#L55

I believe this is more appropriate as a warning or debug log as returning a None value will result in a validation error rather than a failed request. This will create noise when looking for error logs that need to be actioned on.

This also impacts the 5.2.x branch.

[Claude Paroz]

I'm fine with the idea to change the log severity to warning or debug.

[David Buhler]

Hey folks, thanks for picking this up. Is there any chance this will make it into a 5.2.x release?

[Natalia Bidart]

Replying to David Buhler:

Hey folks, thanks for picking this up. Is there any chance this will make it into a 5.2.x release?

Hello David, this change will be available, once merged, in main and in 6.0 and higher. The 5.2 series is currently at beta status so only bugs introduced during the 5.2 development cycle are backported. The code referenced by this ticket is 10-12 years old so it will not receive backports (this is the ​documented backport policy).

[Natalia Bidart]

Hello Hesham! I need to kindly ask you to please read the ​contributing checklist docs carefully as they state that:

If the pull request passes all the criteria below and is not your own, please set the “Triage Stage” on the corresponding Trac ticket to “Ready for checkin”.

Special attention to "and is not your own". You should not set your own PR was ready for checkin. This will be done by a reviewer once your PR is reviewed and approved. When I mentioned in another PR that you need to update the ticket flags, this is not the ticket "Triage Stage", but the booleans "has patch", "patch needs improvement" and "needs tests". I hope this makes sense!

[hesham hatem]

Oh, I see! I sincerely apologize for the misunderstanding. I appreciate you taking the time to explain this, and I’ll be more careful to follow the correct process in the future. Thank you for your patience and guidance!