Opened 10 hours ago
Last modified 13 minutes ago
#36247 new Cleanup/optimization
BaseGeometryWidget unncessarily writes an error log when deserializing malformed geometry
| Reported by: | David Buhler | Owned by: | |
|---|---|---|---|
| Component: | GIS | Version: | 4.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Claude Paroz | Triage Stage: | Unreviewed |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The following bit of error logging happens during deserialization of malformed geometry:
https://github.com/django/django/blob/stable/4.2.x/django/contrib/gis/forms/widgets.py#L55
I believe this is more appropriate as a warning or debug log as returning a None value will result in a validation error rather than a failed request. This will create noise when looking for error logs that need to be actioned on.
This also impacts the 5.2.x branch.
Note:
See TracTickets
for help on using tickets.