Opened 3 hours ago

Last modified 3 hours ago

#36234 new Bug

Restore single_object argument to LogEntry.objects.log_actions()

Reported by: Adam Johnson Owned by:
Component: contrib.admin Version: 5.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Adam Johnson)

#36217 / this part of the PR dropped the single_argument argument in a bug fix release, 5.1.7. Consequently, the method has two signatures in different Django 5.1 versions. I found real-world breakage from this in:

I propose that we restore the argument in Django 5.1 and deprecate it from Django 5.2. It doesn’t make sense that we’d go through the deprecation pathway for the log_action() -> log_actions() migration, but drop an argument in a point release.

Change History (2)

comment:1 by Adam Johnson, 3 hours ago

Description: modified (diff)

comment:2 by Simon Charette, 3 hours ago

Triage Stage: UnreviewedAccepted

Accepted as I don't believe the signature breakage was considered when dropping single_object from it.

Last edited 3 hours ago by Simon Charette (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top