Opened 3 hours ago
Last modified 3 hours ago
#36234 new Bug
Restore single_object argument to LogEntry.objects.log_actions()
| Reported by: | Adam Johnson | Owned by: | |
|---|---|---|---|
| Component: | contrib.admin | Version: | 5.1 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
#36217 / this part of the PR dropped the single_argument argument in a bug fix release, 5.1.7. Consequently, the method has two signatures in different Django 5.1 versions. I found real-world breakage from this in:
- a client project which had calls to
log_actions() - django-import-export - https://github.com/django-import-export/django-import-export/pull/2045
- django-stubs - https://github.com/typeddjango/django-stubs/blob/master/django-stubs/contrib/admin/models.pyi#L33 would need changing
I propose that we restore the argument in Django 5.1 and deprecate it from Django 5.2. It doesn’t make sense that we’d go through the deprecation pathway for the log_action() -> log_actions() migration, but drop an argument in a point release.
Change History (2)
comment:1 by , 3 hours ago
| Description: | modified (diff) |
|---|
comment:2 by , 3 hours ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Note:
See TracTickets
for help on using tickets.
Accepted as I don't believe the signature breakage was considered when dropping
single_objectfrom it.