Opened 6 months ago

Closed 6 weeks ago

#36230 closed Bug (fixed)

Better color contrast for blockquote in admin docs

Reported by: Eliana Rosselli Owned by: LauHerregodts
Component: contrib.admindocs Version: 5.1
Severity: Normal Keywords: accessibility colors contrast
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

In the Admin Docs, the color contrast for text in blockquotes is quite low, making the text very hard to read. An example can be seen in the template tags docs.

Example from Django Admin Docs of a blockquote with poor color contrast on dark mode

The blockquote color is hard-coded to a shade of gray that isn’t visible in the dark theme. It needs switching to an existing CSS variable so the color contrast is good enough in both themes.

Attachments (2)

blockquote-example.png (155.5 KB ) - added by Eliana Rosselli 6 months ago.
Example from Django Admin Docs of a blockquote with poor color contrast on dark mode
image-20250305-100550.png (108.7 KB ) - added by Sarah Boyce 6 months ago.

Download all attachments as: .zip

Change History (14)

by Eliana Rosselli, 6 months ago

Attachment: blockquote-example.png added

Example from Django Admin Docs of a blockquote with poor color contrast on dark mode

comment:1 by Eliana Rosselli, 6 months ago

Component: Uncategorizedcontrib.admindocs
Type: UncategorizedBug

by Sarah Boyce, 6 months ago

Attachment: image-20250305-100550.png added

comment:2 by Sarah Boyce, 6 months ago

Triage Stage: UnreviewedAccepted

Agreed the contrast can be improved, thank you for the ticket

comment:3 by Jordan, 6 months ago

Owner: changed from Eliana Rosselli to Jordan

comment:4 by Jordan, 6 months ago

Has patch: set

comment:6 by Sarah Boyce, 6 months ago

Owner: changed from Jordan to Eliana Rosselli

Thank you Jordan, however, this ticket was recently created and assigned to Eliana. That's because she is working on it (and helping her mentees currently)
Please do not work on tickets that are recently assigned to other folks, if it has been over a month, then perhaps ask if they are working on it still. Over 6 months, then I'd say it's safe to assume it's not being worked on.

in reply to:  6 comment:7 by Jordan, 6 months ago

My apologies, this was my first time ever contributing to open source. I will make sure to find tickets that have not been assigned in the future! Replying to Sarah Boyce:

Thank you Jordan, however, this ticket was recently created and assigned to Eliana. That's because she is working on it (and helping her mentees currently)
Please do not work on tickets that are recently assigned to other folks, if it has been over a month, then perhaps ask if they are working on it still. Over 6 months, then I'd say it's safe to assume it's not being worked on.

comment:8 by Sarah Boyce, 5 months ago

Patch needs improvement: set

comment:9 by Sarah Boyce, 5 months ago

Owner: changed from Eliana Rosselli to Jordan

comment:10 by Thibaud Colas, 6 weeks ago

Owner: changed from Jordan to LauHerregodts
Patch needs improvement: unset
UI/UX: set

I see this hasn’t had activity in a while so I’ve encouraged @LauHerregodts to take this on at the EuroPython sprints. Fixed #36230 -- Improve blockquote contrast #19656.

comment:11 by Thibaud Colas, 6 weeks ago

Triage Stage: AcceptedReady for checkin

comment:12 by GitHub <noreply@…>, 6 weeks ago

Resolution: fixed
Status: assignedclosed

In 896fa85:

Fixed #36230 -- Improved color contrast for blockquote in admin.

Thanks Thibaud Colas for the review.

Note: See TracTickets for help on using tickets.
Back to Top