Opened 6 months ago
Closed 6 weeks ago
#36230 closed Bug (fixed)
Better color contrast for blockquote in admin docs
Reported by: | Eliana Rosselli | Owned by: | LauHerregodts |
---|---|---|---|
Component: | contrib.admindocs | Version: | 5.1 |
Severity: | Normal | Keywords: | accessibility colors contrast |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description
In the Admin Docs, the color contrast for text in blockquotes is quite low, making the text very hard to read. An example can be seen in the template tags docs.
The blockquote color is hard-coded to a shade of gray that isn’t visible in the dark theme. It needs switching to an existing CSS variable so the color contrast is good enough in both themes.
Attachments (2)
Change History (14)
by , 6 months ago
Attachment: | blockquote-example.png added |
---|
comment:1 by , 6 months ago
Component: | Uncategorized → contrib.admindocs |
---|---|
Type: | Uncategorized → Bug |
by , 6 months ago
Attachment: | image-20250305-100550.png added |
---|
comment:2 by , 6 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 6 months ago
Owner: | changed from | to
---|
comment:4 by , 6 months ago
Has patch: | set |
---|
follow-up: 7 comment:6 by , 6 months ago
Owner: | changed from | to
---|
Thank you Jordan, however, this ticket was recently created and assigned to Eliana. That's because she is working on it (and helping her mentees currently)
Please do not work on tickets that are recently assigned to other folks, if it has been over a month, then perhaps ask if they are working on it still. Over 6 months, then I'd say it's safe to assume it's not being worked on.
comment:7 by , 6 months ago
My apologies, this was my first time ever contributing to open source. I will make sure to find tickets that have not been assigned in the future! Replying to Sarah Boyce:
Thank you Jordan, however, this ticket was recently created and assigned to Eliana. That's because she is working on it (and helping her mentees currently)
Please do not work on tickets that are recently assigned to other folks, if it has been over a month, then perhaps ask if they are working on it still. Over 6 months, then I'd say it's safe to assume it's not being worked on.
comment:8 by , 5 months ago
Patch needs improvement: | set |
---|
comment:9 by , 5 months ago
Owner: | changed from | to
---|
comment:10 by , 6 weeks ago
Owner: | changed from | to
---|---|
Patch needs improvement: | unset |
UI/UX: | set |
I see this hasn’t had activity in a while so I’ve encouraged @LauHerregodts to take this on at the EuroPython sprints. Fixed #36230 -- Improve blockquote contrast #19656.
comment:11 by , 6 weeks ago
Triage Stage: | Accepted → Ready for checkin |
---|
Example from Django Admin Docs of a blockquote with poor color contrast on dark mode