Opened 5 days ago
Last modified 83 seconds ago
#36178 assigned Cleanup/optimization
Consistent quoting of object strings in admin delete confirmation messages.
Reported by: | Antoliny | Owned by: | Antoliny |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | delete |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Pull Requests: | 19159 build:success | ||
Description ¶
There is a confirmation message when removing a specific object on the Admin page.
Currently, there are three types of confirmation messages depending on the permissions and on_delete values like this..
As shown in the highlighted part of the image above, single quotes and double quotes are used to emphasize the str object.
I think it would be better to use either single double quotes or quotes consistently for uniformity(I think use double quotes is better).
According to the ticket's flags, the next step(s) to move this issue forward are:
- For a Django committer to do a final review of the patch and merge it if all looks good.
Change History (7)
by , 5 days ago
Attachment: | delete_confirmation_message.png added |
---|
comment:1 by , 5 days ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:2 by , 4 days ago
Summary: | Add quote consistency for object str emphasis in admin delete confirmation messages. → Consistent quoting of object strings in admin delete confirmation messages. |
---|---|
Triage Stage: | Unreviewed → Accepted |
UI/UX: | set |
comment:3 by , 4 days ago
Has patch: | set |
---|
comment:4 by , 4 days ago
Patch needs improvement: | set |
---|---|
Version: | 5.1 → dev |
comment:5 by , 2 days ago
Patch needs improvement: | unset |
---|
comment:6 by , 83 seconds ago
Triage Stage: | Accepted → Ready for checkin |
---|
Think there have been a good number of eyes on this, and I didn't find any other potential-smart-quote-needing spots.
This is likely to be the case in other pages also 👍