Opened 3 days ago

Last modified 21 hours ago

#36178 assigned Cleanup/optimization

Consistent quoting of object strings in admin delete confirmation messages.

Reported by: Antoliny Owned by: Antoliny
Component: contrib.admin Version: dev
Severity: Normal Keywords: delete
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

There is a confirmation message when removing a specific object on the Admin page.
Currently, there are three types of confirmation messages depending on the permissions and on_delete values like this..

As shown in the highlighted part of the image above, single quotes and double quotes are used to emphasize the str object.
I think it would be better to use either single double quotes or quotes consistently for uniformity(I think use double quotes is better).

Attachments (1)

delete_confirmation_message.png​ (103.8 KB ) - added by Antoliny 3 days ago.

Download all attachments as: .zip

Change History (6)

by Antoliny, 3 days ago

Attachment: delete_confirmation_message.png​ added

comment:1 by Antoliny, 3 days ago

Owner: set to Antoliny
Status: new → assigned

comment:2 by Sarah Boyce, 2 days ago

Summary: Add quote consistency for object str emphasis in admin delete confirmation messages. → Consistent quoting of object strings in admin delete confirmation messages.
Triage Stage: Unreviewed → Accepted
UI/UX: set

This is likely to be the case in other pages also 👍

comment:3 by Antoliny, 2 days ago

Has patch: set

comment:4 by Mariusz Felisiak, 2 days ago

Patch needs improvement: set
Version: 5.1 → dev

comment:5 by Antoliny, 21 hours ago

Patch needs improvement: unset
Note: See TracTickets for help on using tickets.
Back to Top